Automatic update-version post-build. Enable precommit; just lint for now #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-mayrgundter
changed the title
pablo-mayrgundter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable update-version post-build.
Precommit just does lint for now.
Git has a problem with changing directories into submodules during a pre-commit hook. There's no clear workaround yet, so not including build for now.
update-version also can't be called in the precommit bc the files staged for the commit can't be altered in flight. So I moved update-version to post-build. This is nice bc it shows you in your staged diff what the version will be when you commit. This is also how Share works.