Indexing Structures/Type Indexing for IFC Step #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static fields. * Added query/expectedType to StepEntityConstructor * Added StepEntityConstructorAbstract * Added type query look ups to schema, that provide query sub-type support. * Added type index to step model base. * Added simple type based lazy entity entraction to step model base. * Shifted the IFC command line application over to the index system. * Added indexing test to ifc step model tests.
pablo-mayrgundter
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
So, can already see these are going to b. a pain. Browser is freezing up typing this.
Let's think about how to separate the manual mods from the regen into a 2-step process where we can review the manual mods, then send a regen PR that is maximally automatic; hopefully that will not even require review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static fields.
This set of changes, along with the matching pull requests for sub-modules, adds index sets and inverted index supports, in particular by entity type.
Related to #Conway 6