Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Geometry Backend to Match Web-Ifc v0.0.44 #66

Merged
merged 24 commits into from
Nov 2, 2023

Conversation

nickcastel50
Copy link
Contributor

@nickcastel50 nickcastel50 commented Oct 10, 2023

This is the accompanying changes to Conway to facilitate the conway_geom PR: #65

  • conway/core: Introduce object pooling for use in geom extract
  • Brep and spline...?
  • NativeVectorGeometry -> StdVector

ifc/ifc_geometry_extraction:

IfcRectangleHollowProfileDef
IfcEllipseProfileDef
IfcCircleHollowProfileDef
IfcIShapeProfileDef
IfcUShapeProfileDef
IfcDerivedProfileDef
IfcCartesianTransformationOperator2D
IfcCartesianTransformationOperator2DnonUniform
IfcLShapeProfileDef
IfcCShapeProfileDef
IfcTShapeProfileDef
IfcZShapeProfileDef

@nickcastel50 nickcastel50 added the enhancement New feature or request label Oct 10, 2023
@pablo-mayrgundter
Copy link
Member

Ping

@nickcastel50 nickcastel50 marked this pull request as ready for review November 2, 2023 19:34
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.. think we need to get this into the netlify preview and go from there.

@nickcastel50 nickcastel50 merged commit 5a6ab8b into bldrs-ai:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants