Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array incremental optimisation #51

Merged
merged 10 commits into from
Sep 25, 2023

Conversation

ConorStokes
Copy link
Contributor

Added incremental array operations as well as singular value skipping.
Used new codegen from #ifcgen.
Improved flatter code-gen attributes in general.

Should be a reasonable performance improvement for extraction cases.

 and other changes
* Fixed skipValue function to handle nested inline types.
* Fixed skipValue function to not have dual branch paths.
* Split stepExtractArrayToken into two functions,
  one is now stepExtractArrayTokenBegin. This function is
  for starting arrays.
*
@ConorStokes ConorStokes added the enhancement New feature or request label Sep 11, 2023
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickcastel50 nickcastel50 merged commit 003be60 into bldrs-ai:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants