-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array incremental optimisation #51
Merged
nickcastel50
merged 10 commits into
bldrs-ai:main
from
ConorStokes:array_incremental_optimisation
Sep 25, 2023
Merged
Array incremental optimisation #51
nickcastel50
merged 10 commits into
bldrs-ai:main
from
ConorStokes:array_incremental_optimisation
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and other changes * Fixed skipValue function to handle nested inline types. * Fixed skipValue function to not have dual branch paths. * Split stepExtractArrayToken into two functions, one is now stepExtractArrayTokenBegin. This function is for starting arrays. *
nickcastel50
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
geometry to .gitignore. * Made element triangle map support multiple primitives per element.
nickcastel50
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added incremental array operations as well as singular value skipping.
Used new codegen from #ifcgen.
Improved flatter code-gen attributes in general.
Should be a reasonable performance improvement for extraction cases.