Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC4 Schema support and associated fixes/tests. #5

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

ConorStokes
Copy link
Contributor

@ConorStokes ConorStokes commented Mar 28, 2023

IFC4 Schema Support for Conway #Conway 4.

  • Added extractLogical and extractCartesianPointList3D to
    ifc_step_models.test.ts.
  • Updated ifc_functions.ts to use all index imports.
  • Updates ifc_functions.ts to support IFC4 use cases.
  • Generated for IFC4!

  ifc_step_models.test.ts.
* Updated ifc_functions.ts to use all index imports.
* Updates ifc_functions.ts to support IFC4 use cases.
* Generated for IFC4!
@ConorStokes ConorStokes added bug Something isn't working enhancement New feature or request labels Mar 28, 2023
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yowza!

Ok, I guess from now on I'll do reviews on the non-gen stuff, then a brief scan of gen stuff, then we should probably do meta-reviews on generated code goals soon.

@ConorStokes ConorStokes merged commit 5e90f32 into bldrs-ai:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants