Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic triangle set cursors #47

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

ConorStokes
Copy link
Contributor

@ConorStokes ConorStokes commented Aug 9, 2023

Dynamic cursors and sets for element sets using doubling trees/COLAs.

  certain values.
* Added cursor utilities tests.
* Added map and iterate cursor utilities.
* Fixed issues with indexSetPointQuery32 sometimes
  erroneously matching unfound values in the set due to lack
  of a full equality check.
* Fixed signed wrap around issues with the low bits check of
  indexSetPointQuery32
  * Added single index set tests.
  * Fixed bounds bug with single_index_set.ts has.
  set for dense ids)
* Added matching cursor.
@ConorStokes ConorStokes marked this pull request as draft August 9, 2023 21:18
@ConorStokes ConorStokes changed the title DRAFT: Dynamic triangle set cursors Dynamic triangle set cursors Aug 9, 2023
* Debugging
* Tests still don't pass, more fixes required.
* Fixed indexSetSearch32 operation not handling 32bit signed wraparound
* Dynamic index set uses doubling tree now.
* Many tests.
@ConorStokes ConorStokes added the enhancement New feature or request label Aug 15, 2023
@ConorStokes ConorStokes marked this pull request as ready for review August 15, 2023 23:01
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ConorStokes ConorStokes merged commit 059c26e into bldrs-ai:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants