Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapped items #39

Merged
merged 5 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ index_ifc_test_draco.glb
index_ifc_test_draco.gltf
.DS_Store
/.vs
Momentum*
9 changes: 4 additions & 5 deletions src/core/canonical_profile.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import { CurveObject, ProfileObject } from '../../dependencies/conway-geom/conway_geometry'
import { Model } from './model'

/**
*
* Represents a profile as cached canonically for extrusion/sweeps
*/
export interface CanonicalProfile {
localID: number
curve: CurveObject | undefined
holes:CurveObject[] | undefined
//TODO(nickcastel50): IfcJS has an isConvex variable, appears unused
//isConvex:boolean
// TODO(nickcastel50): IfcJS has an isConvex variable, appears unused
// isConvex:boolean
profiles: CanonicalProfile[] | undefined
nativeProfile:ProfileObject | undefined
nativeProfile:ProfileObject | undefined
}
1 change: 0 additions & 1 deletion src/core/model.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { CurveObject } from '../../dependencies/conway-geom/conway_geometry'
import { CanonicalMesh } from './canonical_mesh'
import {CanonicalProfile} from './canonical_profile'
import { Entity } from './entity'
Expand Down
1 change: 0 additions & 1 deletion src/ifc/ifc_command_line_main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ async function geometryExtraction(model: IfcStepModel, fileNameNoExtension: stri

const clonedGeometry = geometry.geometry.clone()


clonedGeometry.applyTransform(nativeTransform)

if (fullGeometry === void 0) {
Expand Down
3 changes: 2 additions & 1 deletion src/ifc/ifc_geometry_extraction.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ function extractGeometry(): ExtractResult {
*/
function getMeshSize(): Number {
let canonicalMeshGeometryCount = 0
for (const [_, nativeTransform, geometry] of conwayModel.getScene().walk()) {
// eslint-disable-next-line no-unused-vars
for (const [_, _nativeTransform, geometry] of conwayModel.getScene().walk()) {
if (geometry.type === CanonicalMeshType.BUFFER_GEOMETRY) {
canonicalMeshGeometryCount++
}
Expand Down
Loading