Extraction tests added to Conway, as well as extending the console app to do queries in markdown for point tests. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out. * Added field extraction to the command line app for ad-hoc testing * Added express id filtering to the command line app for ad-hoc testing * Added type filtering to the command line app for ad-hoc testing * Made the command line app output markdown compliant tables * Added yarg as a dependency for command line parsing. * Added a bunch of extraction tests for the parser. * Added an explict IfcStepModel class. * Added an explict IfcStepParser class. * Code gen has better spacing. * Added special "parseDataToModel" method to the IfcStepParser, which simplifies the interface and makes it closer to one step. * Added straight extraction test that counts the extracted rows from parsing the model and initialising an array. * Added a specific test for extracting an IFCGEOMETRICREPRESENTATIONSUBCONTEXT, because it has complex derived members that are required to deal with proxying overridden members. * Added a specific tests for extracting some scientific format numbers from numbers from IFCGEOMETRICREPRESENTATIONSUBCONTEXT and IFCCARTESIANPOINT. * Added a specific test for IFC step array extraction, including reference arrays and string arrays. * Added a specific test for IFC enum extraction. * Added a specific test for IFC string extraction with unicode. *
ConorStokes
added
bug
| @@ -39,6 +39,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "buffer": "^6.0.3", | |||
| "smart-buffer": "^4.2.0" | |||
| "smart-buffer": "^4.2.0", | |||
pablo-mayrgundter
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #2, adding extra extraction tests to Conway and has a dependency on #conway-ds 1 and #IFC-Gen 1