Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conway api surface - connected positional transform matrices to meshes + more transforms + scaffolding for further transforms #20

Merged
merged 17 commits into from
May 30, 2023
Merged

Conway api surface - connected positional transform matrices to meshes + more transforms + scaffolding for further transforms #20

merged 17 commits into from
May 30, 2023

Conversation

nickcastel50
Copy link
Contributor

This pull request satisfies most of Momentum.ifc's geometry. Includes:

  • Proper topographical sort / element walk for geometry extraction
  • Connecting transform matrices to mesh geometry.
  • Scaffolding added for IfcBooleanResult + IfcExtrudedAreaSolid + various IfcCurve types

There is an accompanying PR for Conway-Geom that should be accepted prior to this one.

nickcastel50 added 17 commits May 4, 2023 14:24
@nickcastel50
* output geometry files use base name of input file + updated conway-…
4e39f16 
…geom to latest main
@nickcastel50
Update conway-geom
bd5277c
@nickcastel50
* WIP processing geometry + linking transforms with geometry
cd2bcc2
@nickcastel50
* Update conway-ds + update IFC-gen
a69c284
@nickcastel50
Merge branch 'main' into conway_api_surface
0065fa0
@nickcastel50
* update conway-ds + update IFC-gen
0cdabe0
@nickcastel50
* Updates for transform support + updated conway-geom dependency
e229c3a
@nickcastel50
* added mesh splice / removal for geometry with no valid transform
a6af325
@nickcastel50
Merge remote-tracking branch 'upstream'
789cdb8
@nickcastel50
Merge branch 'main' into conway_api_surface
8c3d021
@nickcastel50
* updated conway-ds + IFC-gen
2dfdc8a
@nickcastel50
Update conway-ds
6f901ad
@nickcastel50
* Update typescript to conform to linter
4eb7d4c
@nickcastel50
Update conway-geom
2382dde
@nickcastel50
* started scaffolding on IfcBooleanResult + IfcExtrudedAreaSolid + Cu…
4fc2dad 
…rves
@nickcastel50
*Update conway-geom
5090500
@nickcastel50
* Update conway-geom
8d08dcd
@nickcastel50 nickcastel50 added the enhancement New feature or request label May 26, 2023
@nickcastel50 nickcastel50 requested a review from ConorStokes May 26, 2023 18:53
@nickcastel50 nickcastel50 mentioned this pull request May 26, 2023
Merged
ConorStokes
ConorStokes approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@ConorStokes ConorStokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we move forwards I thin we want to break-up ifc_geometry_extraction.ts, not necessarily now but it's worrying as it starts to get towards 1,000 lines that it may become unreadable.

@nickcastel50
Copy link
Contributor Author

As we move forwards I thin we want to break-up ifc_geometry_extraction.ts, not necessarily now but it's worrying as it starts to get towards 1,000 lines that it may become unreadable.

Agreed, will address when we refactor.

@nickcastel50 nickcastel50 merged commit afa6087 into bldrs-ai:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConorStokes ConorStokes ConorStokes approved these changes

Assignees

@ConorStokes ConorStokes

Labels
enhancement New feature or request
Projects
No open projects
bldrs.ai
Status: Closed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickcastel50 @ConorStokes