Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP214 Scaffold test + External Mapping Refactor #131

Merged

Conversation

ConorStokes
Copy link
Contributor

  • Added tests for external mapping
  • Added tests for the AP214 step model
  • Refactored to add specific types for step 214 and IFC external mappings
  • Added supporting code/minor refactor for adding specific types for external mappings
  • External mappings are now type identifiable/guardable in code

* Added tests for the AP214 step model
* Refactored to add specific types for step 214 and IFC external mappings
* Added supporting code/minor refactor for adding specific types for external mappings
* External mappings are now type identifiable/guardable in code
@ConorStokes ConorStokes added the enhancement New feature or request label Feb 14, 2024
@ConorStokes ConorStokes self-assigned this Feb 14, 2024
@ConorStokes ConorStokes linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ConorStokes ConorStokes merged commit ee8157e into bldrs-ai:STEP_gen Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AP214: Implement tests post geometry scaffold
2 participants