Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerated code with new formatting and fixed tests to match #12

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Regenerated code with new formatting and fixed tests to match #12

merged 1 commit into from
Apr 25, 2023

Conversation

ConorStokes
Copy link
Contributor

  • Regenerated code with the updated IFC code-gen.
  • Deleted previously generated files with .bldrs extension.
  • New generated files have .gen extension, comments saying they are generated and formatting should be much closer to other JS bldrs code.
  • Updated tests and reference code to match generated code.
  • Spent a fair bit of time reviewing generated code for problems, all tests pass and the code seems good.

Related to issue #11.

@ConorStokes ConorStokes added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 24, 2023
@ConorStokes ConorStokes changed the title Regenerated code with new formatting and fixed tests to match DRAFT: Regenerated code with new formatting and fixed tests to match Apr 24, 2023
@pablo-mayrgundter pablo-mayrgundter changed the title DRAFT: Regenerated code with new formatting and fixed tests to match Regenerated code with new formatting and fixed tests to match Apr 24, 2023
@pablo-mayrgundter pablo-mayrgundter self-assigned this Apr 24, 2023
pablo-mayrgundter
pablo-mayrgundter approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Rubber stamp :)

@ConorStokes ConorStokes merged commit 6efb955 into bldrs-ai:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-mayrgundter pablo-mayrgundter pablo-mayrgundter approved these changes

Assignees

@pablo-mayrgundter pablo-mayrgundter

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
No open projects
bldrs.ai
Status: Closed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConorStokes @pablo-mayrgundter