Add Husky-powered pre-commit hook #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,8 @@ | |||
| "serve": "yarn build && node config/serve.js", | |||
| "lint": "yarn eslint `find src -name '*.jsx'` `find src -name '*.js'`", | |||
| "test": "jest", | |||
| "precommit": "yarn test && yarn lint" | |||
| "precommit": "yarn test && yarn lint", | |||
| "prepare": "husky install" | |||
There was a problem hiding this comment.
Can we call this smth like husky-init
There was a problem hiding this comment.
The lifecycle script must be called prepare -- that's a special part of the Yarn lifecycle that is automatically triggered when certain things are run.
pablo-mayrgundter
approved these changes
Apr 13, 2022
OlegMoshkovich
pushed a commit
to OlegMoshkovich/Share
that referenced
this pull request
Apr 27, 2022
my comment is wrong.. apparently name "prepare" is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to introduce Husky as facility for installing and executing pre-commit hooks within the project.