Extend search bar functionality to open IFCs hosted on GitHub. #174
Conversation
OlegMoshkovich
changed the title
OlegMoshkovich
force-pushed
the
search_URL
branch
from
33b4521 to
31faac1
Compare
There was a problem hiding this comment.
The demo link isn't working for me.
Please add tests for the new code in ShareRoutes, and also the instructions page you point to still looks in progress, that right? I was noting that I think it needs more introductory text to help orient the user.
https://github.com/bldrs-ai/Share/wiki/GitHub-model-hosting
OlegMoshkovich
force-pushed
the
search_URL
branch
from
3e088a9 to
b88403e
Compare
|
The link should work now. GitHub model hosting: @pablo-mayrgundter PTAL. |
|
@pablo-mayrgundter PTAL! |
|
I accidentally pushed my changes to your fork&branch (a lot of that lately! 🫣) but I think we like it? Will wait to hear back your comments |
|
Heya, I'm leaving for the weekend tomorrow so in the interest of time going to merge. You said you were good and just had those comments. I did update to handle more types of links in looksLikeLink and then answered the other questions. So I think everything is addressed. |
…-ai#174) * add a method to check if the input is URL * rename * extract url parameters from search input * debug the model path * add styles and funcitons to the search bar * moved url methods to share routes * new build * new build * add test to share routes * add test to share routes * add test to share routes * fixes * add tests + parse url method * add isURL and error messaging * clean up * clean up * add fixes * fixes * search: thoughts on how to use regex capture group for github url parsing * search: support both full URLs and paths in search. * search: More case handling for load-by-link in searchbar. * search: little more refactoring and test cases. Co-authored-by: Pablo Mayrgundter <[email protected]>
https://olegmoshkovich.github.io/Share/share/v/gh/Swiss-Property-AG/Portfolio/main/EISVOGEL.ifc