Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 1296-mobile-drawer-tabs-dont-auto-select-or-order-correctly #1308

Merged

Conversation

nickcastel50
Copy link
Contributor

Addresses #1296

@nickcastel50 nickcastel50 added the enhancement New feature or request label Dec 12, 2024
@nickcastel50 nickcastel50 self-assigned this Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 4797252
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/675b8855e4ee8100079a5455
😎 Deploy Preview https://deploy-preview-1308--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 0 (no change from production)
Accessibility: 87 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for bldrs-share-prod ready!

Name Link
🔨 Latest commit 4797252
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-prod/deploys/675b8855214e2200089d7737
😎 Deploy Preview https://deploy-preview-1308--bldrs-share-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add e2e test

@nickcastel50 nickcastel50 marked this pull request as ready for review December 13, 2024 01:05
@nickcastel50 nickcastel50 merged commit 82e1b46 into main Dec 13, 2024
10 checks passed
@nickcastel50 nickcastel50 changed the title Address Issue 1296 1296-mobile-drawer-tabs-dont-auto-select-or-order-correctly Dec 13, 2024
@pablo-mayrgundter pablo-mayrgundter changed the title 1296-mobile-drawer-tabs-dont-auto-select-or-order-correctly Fix: 1296-mobile-drawer-tabs-dont-auto-select-or-order-correctly Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants