Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue from bundler require error #330

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Rescue from bundler require error #330

merged 1 commit into from
Apr 14, 2018

Conversation

jaydorsey
Copy link
Contributor

Resolves an issue where spring tries to File.expand_path and the
$HOME variable is not set.

This was identified as an issue with AWS Elastic Beanstalk deployments

Resolves an issue where spring tries to `File.expand_path` and the
`$HOME` variable is not set.

This was identified as an issue with certain cloud provider
environments.
@cadwallion cadwallion self-assigned this Apr 13, 2018
@jaydorsey
Copy link
Contributor Author

I've tested the behavior of expand_path locally, with Ruby 2.3.3, 2.4.2, and 2.5.0

unset HOME && ruby -e "puts File.expand_path('~/test.rb')" breaks consistently with an ArgumentError in 2.3.3. Hence, the PR (Amazon used 2.3.3 for their Elastic Beanstalk environment)

2.4.2 and 2.5.0 appear unaffected.

The ruby-doc for all 3 ruby versions appears consistent, even though the behavior isn't.

@cadwallion
Copy link
Collaborator

Thank you for reopening this PR so we could get this cleared up!

@cadwallion cadwallion merged commit 3b096d2 into bkeepers:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants