Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments are executed #336

Closed
alainravet opened this issue Apr 22, 2018 · 2 comments · Fixed by #340
Closed

comments are executed #336

alainravet opened this issue Apr 22, 2018 · 2 comments · Fixed by #340

Comments

@alainravet
Copy link

file: .env.development:

# Uncomment to activate:
# DO_X=anything

with dot-env 2.2.2

bundler exec rails c
2.5.0 :001 > ENV['DO_X']
 => nil         <--------- GOOD

with dot-env 2.3.0

bundler exec rails c
2.5.0 :001 > ENV['DO_X']
 => "anything"         <--------- BAD
@ykzts ykzts mentioned this issue Apr 23, 2018
Merged
@zarqman zarqman mentioned this issue Apr 23, 2018
Closed
@jonmagic
Copy link
Collaborator

Thank you for the bug report. Looking into potential solutions now.

@jonmagic jonmagic mentioned this issue Apr 24, 2018
Merged
5 tasks
@jonmagic
Copy link
Collaborator

We just shipped version 2.4.0 which removes the Parse multiline values support added in 2.3.0 and fixes the parsing regressions.

@jonmagic jonmagic mentioned this issue Apr 24, 2018
Closed
phallstrom added a commit to railslink/railslink that referenced this issue Oct 27, 2018
@phallstrom
update dotenv
b3eb4fd 
last version would happily parse ENV vars that were commented out. ugh.

see bkeepers/dotenv#336
@phallstrom phallstrom mentioned this issue Oct 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 2.3.0 regressions and release 2.4.0 bkeepers/dotenv
2 participants
@jonmagic @alainravet