Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for specifing in an account not defined in flow.json as… #136

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

bjartek
Copy link
Owner

@bjartek bjartek commented Aug 29, 2023

… signer

Closes #???

Description


For contributor use:

  • Targeted PR against main branch
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Unit Test Results

259 tests  +1   259 ✔️ +1   54s ⏱️ -5s
    6 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit c5b6910. ± Comparison against base commit 8331a93.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Pull Request Test Coverage Report for Build 6548023598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 149 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.6%) to 74.326%

Files with Coverage Reduction New Missed Lines %
result.go 27 76.22%
interaction_builder.go 42 84.42%
state.go 80 82.16%
Totals Coverage Status
Change from base Build 6548025647: -0.6%
Covered Lines: 2371
Relevant Lines: 3190

💛 - Coveralls

@bjartek bjartek merged commit 759fcf0 into main Oct 17, 2023
5 checks passed
@bjartek bjartek deleted the add-manual-signer branch October 17, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant