Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/PM-8113 - Deprecate TwoFactorComponentRefactor feature flag in favor … #5120

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JaredSnider-Bitwarden
Copy link
Contributor

…of UnauthenticatedExtensionUIRefresh feature flag.

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…of UnauthenticatedExtensionUIRefresh feature flag.
@JaredSnider-Bitwarden JaredSnider-Bitwarden marked this pull request as draft December 5, 2024 16:56
Copy link
Contributor

github-actions bot commented Dec 5, 2024

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Two Factor Component Refactor two-factor-component-refactor ✅ all references removed

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.92%. Comparing base (44bf561) to head (942b6ba).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5120      +/-   ##
==========================================
- Coverage   43.06%   42.92%   -0.14%     
==========================================
  Files        1412     1431      +19     
  Lines       64775    65377     +602     
  Branches     5920     5988      +68     
==========================================
+ Hits        27894    28063     +169     
- Misses      35649    36067     +418     
- Partials     1232     1247      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Logo
Checkmarx One – Scan Summary & Details3afa7b7d-fb43-49ec-8df3-63a8c26ab83f

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/LicensesController.cs: 44
LOW Heap_Inspection /src/Core/Billing/Licenses/LicenseConstants.cs: 33
LOW Heap_Inspection /src/Core/Billing/Licenses/LicenseConstants.cs: 27
LOW Unpinned Actions Full Length Commit SHA /build.yml: 581
LOW Unpinned Actions Full Length Commit SHA /build.yml: 666
LOW Unpinned Actions Full Length Commit SHA /build.yml: 618
LOW Unpinned Actions Full Length Commit SHA /build.yml: 547
LOW Unsafe_Use_Of_Target_blank /src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForTwoFactorPolicy.html.hbs: 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant