Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autofill inputs meant for password recovery #1999

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

gabrielfin
Copy link
Contributor

This adds the fix I suggested in issue #1956 . I have tested it and it works.

Some websites have a form to recover forgotten password in the same page as the login form. Bitwarden incorrectly autofills that form when the input is named "forgotpassword", because it contains the word "password".

Here's an example: https://demo.phplist.org/lists/admin/

@eliykat eliykat self-assigned this Aug 10, 2021
@gabrielfin
Copy link
Contributor Author

Is there any news on this?

I use PHPList a lot, and this shows the password in plaintext to anyone watching or recording the screen in videoconference meetings.

Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually hesitant to change autofill logic to fix a single site. It might break other sites or cause regressions, and we don't have any good automated testing to detect that.

However, this seems like a reasonable change in general, I can imagine this coming up for a few sites and I doubt we'd want to fill a password in these circumstances. The ignoreList is fairly targeted to begin with. Let's do it!

Unless there are any issues, this will be included in the November release. If you want to disable that field in the meantime, you can create a custom field for the input. Make it a Text custom field but leave the value empty and it should prevent anything else from being filled in that field.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants