Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox plugin opens browser side panel (sidebar) on vault lock #900

Closed
thibaut-decherit opened this issue Mar 20, 2019 · 25 comments
Closed
Labels
browser Browser Extension bug

Comments

@thibaut-decherit
Copy link

My Firefox side panel defaults to this plugin.
Since last update (or so), everytime the vault is being locked (either manually or thanks to the auto lock feature) it will open the side panel by itself to display the plugin.

It happens a couple seconds after lock, even if I didn't use the side panel during this session.
It doesn't happen if side panel is set to display something else (bookmarks, history...)

When it happens the red padlock disappears briefly from the plugin icon, like when the vault is unlocked (even if side panel is not set to display Bitwarden)

Bug encountered on Windows and Linux.

Steps to reproduce:

  • Log in, either throught plugin's widget (not sure if it's the right word) or side panel
  • Lock vault (and close side panel if you manipulated the vault through it)
  • Wait for around 7 seconds
@kspearrin
Copy link
Member

kspearrin commented Mar 20, 2019

This seems to happen because we now call browser.runtime.reload() shortly after the extension is locked to make sure unmanaged memory is properly purged. It's a shame that Firefox re-opens the sidebar when this occurs, since that definitely is going to be annoying. Opera doesn't seem to do this with their sidebar.

Maybe we can switch to window.reload() instead.

@kspearrin kspearrin added the bug label Mar 20, 2019
@GabeDuarteM
Copy link

GabeDuarteM commented Apr 4, 2019

@kspearrin I'm also having a very similar problem in Opera. When the vault is locked, either automatically or manually, the extensions bar (which I normally leave hidden) is automatically shown, so I have to manually hide it again, which is very annoying.

Top left corner shows problem
image

I think by the description of this issue that both are probably caused by the same thing, but just in case, do you want me to file another bug? The difference is that in firefox this happens on the sidebar, and on opera on the extensions bar

@kspearrin
Copy link
Member

Should be fixed next version for both Opera and Firefox

@Jourond
Copy link

Jourond commented May 11, 2019

This issue is still happening for me. On each lock the sidebar opens back up and I can't disable it.

MacOS
Firefox 66.0.5 (64-bit)
Bitwarden Extension 1.39.3

@kspearrin
Copy link
Member

@Jourond It is fixed in the next version.

@plavirudar
Copy link

plavirudar commented Jun 17, 2019

@Jourond It is fixed in the next version.

@kspearrin When can we expect an update to the next version? The Firefox addon https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager/ seems to have been updated on Mar 14 (over 3 months ago). Is there any place that we can download a more recent build?

@Crocmagnon
Copy link
Contributor

I guess not, the release page on GitHub doesn't list any more recent release : https://github.com/bitwarden/browser/releases

@InordinateDuck
Copy link

InordinateDuck commented Jun 21, 2019

This definitely needs a second pass. The only thing stopping me from using Firefox right now is the fact that this add on is causing that sidebar to load every time it locks. This was not fixed yet.

@Shaltz
Copy link

Shaltz commented Feb 28, 2021

Same here, I'm on firefox 86.0, and every time I launch FF, the BW sidebar loads up on EVERY window...
Thats quite annonying... any ETA when that should really be fixed ??

@eliykat eliykat changed the title Firefox plugin opens browser side panel on vault lock Firefox plugin opens browser side panel (sidebar) on vault lock Mar 1, 2021
@itsayellow
Copy link

Can this bug be reopened? I just installed the bitwarden plugin on the newest firefox and every time my vault times out it opens every sidebar on every firefox window. Very frustrating.

@eliykat
Copy link
Member

eliykat commented Mar 19, 2021

Reopened and queued for reproduction/triage. Can you please provide your OS, Firefox and Bitwarden versions @Shaltz and @itsayellow? Have you changed any default settings that might be related - e.g. default hotkeys, vault timeout behaviour?

@eliykat eliykat reopened this Mar 19, 2021
@itsayellow
Copy link

OS: MacOS Big Sur 11.2.3
Firefox: 86.0.1
Bitwarden plugin: Version: 1.49.1

thanks for reopening!

@beytun
Copy link

beytun commented Mar 24, 2021

I have the same issue.
OS: MacOS Catalina 10.15.7
Firefox: 88.0b2 (64-bit)
Bitwarden plugin: 1.49.1

@itsayellow
Copy link

To add more information, I haven't seen bitwarden open my sidebar again. It's possible it only happened the first time the vault timed out after I installed it. (My current versions: Firefox 87.0, Bitwarden 1.49.1)

@Allesuah
Copy link

Allesuah commented Apr 7, 2021

Hi,

I have just installed the plugin and Im getting the same error.

OS: Windows 10 (1904.867)
Firefox: 87.0
Bitwarden plugin: 1.49.1

@n0valis
Copy link

n0valis commented Feb 2, 2022

I have the same problem on
Debian Bullseye
Firefox 91.5.0esr 64-Bit
Bitwarden 1.55.0

I never use the sidepanel and would like it inactive completely.

@JJ-White
Copy link

Same issue here, sidebar opens with Bitwarden on every new Firefox window. System specs:

Ubuntu 21.10
Mozilla Firefox 99.0.1
Bitwarden plugin 1.57.0

The workaround mentioned in the linked issue (#1991) where you switch to another sidebar tab (e.g. bookmarks), close the sidebar, and exit Firefox with Ctrl + Q seems to have worked for me.

@Hinton Hinton added the browser Browser Extension label May 5, 2022
addisonbeck pushed a commit that referenced this issue May 5, 2022
eliykat pushed a commit that referenced this issue Jun 3, 2022
* [Reset Password] Enrollment actions

* Update jslib (0951424 -> f4f00b1)

* Added status icon
@atjbramley
Copy link
Contributor

Hi @thibaut-decherit ,

I attempted to reproduce your issue and was unable to do so using the Bitwarden release 2023.9.2 on macOS 14.1 and Firefox 118.0.2.

I suspect that this issue was fixed by the code changes referenced above.

We use GitHub issues as a place to track bugs and other development related issues. If this issue persists, please write us back using our contact form, so we can continue troubleshooting: https://bitwarden.com/contact/

You can include a link to this issue in the message content.

The issue here will be closed.

Thanks!

@eirnym
Copy link

eirnym commented Oct 27, 2023

Same here, please reopen the issue.

Bitwarden side panel reopens in every window every time when I open Firefox and I have to manually go through all the windows and close sidepanel.

I'm ok with a notification on the icon or as a bubble that I have to reopen the safe before using Bitwarden, but sidebar is too much

macOS Ventura 13.6
Firefox 119.0
Bitwarden plugin 2023.9.2

@atjbramley
Copy link
Contributor

Hi @eirnym, can you please update to the latest version of the Bitwarden plugin.
If the issue persists, please contact support using the link above and we'll work with you to see if this can be reproduced.
We look forward to receiving your email with our Support Team.

@eirnym
Copy link

eirnym commented Oct 27, 2023

You presumably fixed it in 2019, then in 2021. Why issue persists in 2023?

@eirnym
Copy link

eirnym commented Oct 27, 2023

This is the latest one. This way of nudging is the worse of any possible.

Zrzut ekranu 2023-10-27 o 09 35 40

@eirnym
Copy link

eirnym commented Oct 27, 2023

Please, reopen the issue

@Greenderella
Copy link
Member

Hello,

We've thoroughly investigated this issue across multiple platforms, including macOS, Windows, and Linux, and have been unable to reproduce it.

If you're still experiencing this problem after performing a clean installation of the browser extension by removing any leftover data (instructions here), you can also try refreshing your Firefox profile using Mozilla's instructions.

If your issue persists, please don't hesitate to reach out to us through our contact form, so we can continue troubleshooting.

The issue will remain closed.

Thank you!

@Greenderella Greenderella closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@eirnym
Copy link

eirnym commented Oct 27, 2023

There's a few interesting details found during our local investigation:

  • We use self-hosted BitWarden
  • Default lock mode is "On browser restart" (translated from "Po restarcie przeglądarki")
  • I don't know the rest of settings on the server.
  • I have 5+ opened Firefox windows

After I clean all browser settings (close firefox, literally rm -rf firefox-profile-folder, create new profile and install Bitwarden plugin) and create a new account, I can reproduce the issue.

The issue persists until I change lock mode. After I set plugin lock mode to "Never" ("Nigdy") and I close all previously opened sidebars and then restart Firefox, then on that specific account I can't reproduce the issue. Closed sidebars persist even I log out and log in back.

I believe this issue is too hard to reproduce and test because it needs very specific conditions (like first-time login).

PS: I don't know if there's a setting to show this plugin sidebar by default or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests