Use custom virtual scroll strategy (#2002)

* update jslib * Use custom virtual scroll strategy
bitwarden · Aug 11, 2021 · 69c8928 · 69c8928
1 parent 090e9f3
commit 69c8928
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/jslib b/jslib
diff --git a/src/popup/app.module.ts b/src/popup/app.module.ts
@@ -57,6 +57,7 @@ import { ApiActionDirective } from 'jslib-angular/directives/api-action.directiv
 import { AutofocusDirective } from 'jslib-angular/directives/autofocus.directive';
 import { BlurClickDirective } from 'jslib-angular/directives/blur-click.directive';
 import { BoxRowDirective } from 'jslib-angular/directives/box-row.directive';
+import { CipherListVirtualScroll } from 'jslib-angular/directives/cipherListVirtualScroll.directive';
 import { FallbackSrcDirective } from 'jslib-angular/directives/fallback-src.directive';
 import { InputVerbatimDirective } from 'jslib-angular/directives/input-verbatim.directive';
 import { SelectCopyDirective } from 'jslib-angular/directives/select-copy.directive';
@@ -190,6 +191,7 @@ registerLocaleData(localeZhTw, 'zh-TW');
         BlurClickDirective,
         BoxRowDirective,
         CalloutComponent,
+        CipherListVirtualScroll,
         CipherRowComponent,
         CiphersComponent,
         CollectionsComponent,

diff --git a/src/popup/components/cipher-row.component.html b/src/popup/components/cipher-row.component.html
@@ -1,5 +1,5 @@
 <a (click)="selectCipher(cipher)" (dblclick)="launchCipher(cipher)" href="#" appStopClick
-    title="{{title}} - {{cipher.name}}" class="box-content-row box-content-row-flex">
+    title="{{title}} - {{cipher.name}}" class="box-content-row box-content-row-flex virtual-scroll-item">
     <div class="row-main">
         <app-vault-icon [cipher]="cipher"></app-vault-icon>
         <div class="row-main-content">

diff --git a/src/popup/vault/ciphers.component.html b/src/popup/vault/ciphers.component.html
@@ -63,7 +63,8 @@
                 </button>
             </ng-container>
         </div>
-        <cdk-virtual-scroll-viewport itemSize="46" *ngIf="ciphers.length" #virtualScrollViewport>
+        <cdk-virtual-scroll-viewport itemSize="46" minBufferPx="400" maxBufferPx="600" *ngIf="ciphers.length"
+            #virtualScrollViewport>
             <div class="box list only-list">
                 <div class="box-header">
                     {{groupingTitle}}

diff --git a/src/popup/vault/groupings.component.html b/src/popup/vault/groupings.component.html
@@ -145,7 +145,8 @@
         <div class="no-items" *ngIf="!ciphers || !ciphers.length">
             <p>{{'noItemsInList' | i18n}}</p>
         </div>
-        <cdk-virtual-scroll-viewport itemSize="46" *ngIf="ciphers && ciphers.length > 0">
+        <cdk-virtual-scroll-viewport itemSize="46" minBufferPx="400" maxBufferPx="600"
+            *ngIf="ciphers && ciphers.length > 0">
             <div class="box list full-list">
                 <div class="box-content">
                     <app-cipher-row *cdkVirtualFor="let searchedCipher of ciphers" [cipher]="searchedCipher"
+24 −42		angular/package-lock.json
+0 −1		angular/package.json
+6 −42		angular/src/components/ciphers.component.ts
+1 −1		angular/src/components/set-password.component.ts
+97 −0		angular/src/components/update-temp-password.component.ts
+62 −0		angular/src/directives/cipherListVirtualScroll.directive.ts
+5 −2		common/src/abstractions/api.service.ts
+2 −0		common/src/abstractions/user.service.ts
+3 −0		common/src/enums/eventType.ts
+9 −0		common/src/misc/utils.ts
+5 −0		common/src/models/request/provider/providerOrganizationCreateRequest.ts
+3 −1		common/src/models/request/tokenRequest.ts
+5 −0		common/src/models/request/updateTempPasswordRequest.ts
+2 −0		common/src/models/response/profileResponse.ts
+9 −3		common/src/services/api.service.ts
+1 −0		common/src/services/sync.service.ts
+15 −0		common/src/services/user.service.ts