Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workers API #2149

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Update workers API #2149

merged 3 commits into from
Apr 20, 2020

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Apr 20, 2020 •
edited
Loading

PR for #2121

  • get_all_workers: add an optional is_expired parameter 
    database_api::get_all_workers( const optional<bool> is_expired )
  • get_workers_by_account: remove optional from the return type, improve performance 
    vector<worker_object> get_workers_by_account(const std::string account_name_or_id)

abitmore added 3 commits April 20, 2020 00:50
@abitmore
Update database APIs related to workers
5a1dc72 
- get_all_workers: add an optional `is_expired` parameter
- get_workers_by_account: remove `optional` from the return type, improve performance
@abitmore
Add test cases for get_all_workers API
aaf9693
@abitmore
Add test cases for get_workers_by_account API
4e04c1d
@abitmore abitmore linked an issue Apr 20, 2020 that may be closed by this pull request
NEWAPI - Query only worker objects that have not expired. #2121
Closed
@abitmore abitmore mentioned this pull request Apr 20, 2020
Closed
oxarbitrage
oxarbitrage approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abitmore abitmore merged commit a264f91 into hardfork Apr 20, 2020
@abitmore abitmore deleted the pr-2121-worker-api branch April 20, 2020 20:59
@MichelSantos MichelSantos mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@MichelSantos MichelSantos Awaiting requested review from MichelSantos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.

NEWAPI - Query only worker objects that have not expired.
2 participants
@abitmore @oxarbitrage