Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Specify signing keys #2049

Merged
merged 8 commits into from
Nov 19, 2019
Merged

CLI: Specify signing keys #2049

merged 8 commits into from
Nov 19, 2019

Conversation

MichelSantos
Copy link
Contributor

PR for Issue #2048

@pmconrad
Copy link
Contributor

Travis fails:

fatal error in "cli_sign_message": signal: SIGSEGV, si_code: 0 (memory access violation at address: 0x00000080)
/home/travis/build/bitshares/bitshares-core/tests/cli/main.cpp(1199): last checkpoint

@MichelSantos
CLI: Unit test of additional signing key when signing a transaction
16e8254 
CLI: Unit test of additional signing key when signing a transaction builder
@pmconrad pmconrad mentioned this pull request Nov 12, 2019
Merged
@pmconrad
Copy link
Contributor

I believe you are correct that the error is unrelated to your change.

pmconrad
pmconrad reviewed Nov 14, 2019
View reviewed changes
tests/cli/main.cpp Outdated Show resolved Hide resolved
pmconrad
pmconrad reviewed Nov 16, 2019
View reviewed changes
tests/cli/main.cpp Outdated Show resolved Hide resolved
pmconrad
pmconrad suggested changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Some comments still need tweaking though.

tests/cli/main.cpp
con.wallet_api_ptr->register_account(
"alice", alice_bki.pub_key, alice_bki.pub_key, "nathan", "nathan", 0, true
);
const account_object &alice_acc = con.wallet_api_ptr->get_account("alice");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet::get_account returns an account object, not a reference (unlike database::get_account).

tests/cli/main.cpp Outdated Show resolved Hide resolved
tests/cli/main.cpp Outdated Show resolved Hide resolved
tests/cli/main.cpp Outdated Show resolved Hide resolved
tests/cli/main.cpp Outdated Show resolved Hide resolved
tests/cli/main.cpp Outdated Show resolved Hide resolved
@MichelSantos
Copy link
Contributor Author

@pmconrad Thanks very much for your fix

@jmjatlanta jmjatlanta merged commit 70500fd into bitshares:release Nov 19, 2019
@MichelSantos MichelSantos mentioned this pull request Nov 28, 2019
Closed
@pmconrad pmconrad mentioned this pull request Nov 28, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
4 participants
@MichelSantos @pmconrad @jmjatlanta @abitmore