Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional BSIP 40 unit tests #2044

Merged
merged 20 commits into from
Nov 7, 2019
Merged

Additional BSIP 40 unit tests #2044

merged 20 commits into from
Nov 7, 2019

Conversation

MichelSantos
Copy link
Contributor

No description provided.

@MichelSantos
BSIP 40: Improvements to the unit test comments
e7d52b1
@MichelSantos
BSIP 40: Unit test expansion to check the JSON-formatted exception fo…
4037b9d 
…r appropriate rejection reasons
@MichelSantos
BSIP 40: Unit test of optional field restriction
ef8a7f9
@MichelSantos
BSIP 40: Unit test of not equal (ne) restriction
2909875
@MichelSantos
BSIP 40: Unit test of not in (not_in) restriction
7c64255
@MichelSantos
BSIP 40: Unit test of has none (has_none) restriction
a92c675
@MichelSantos
BSIP 40: Unit test of has all (has_all) restriction
95ebc96
@MichelSantos
BSIP 40: Unit test of in (in) restriction
b8cc105
@MichelSantos
BSIP 40: Unit test of greater than or equal to (ge) restriction
1c213c5
@MichelSantos
BSIP 40: Unit test of HTLC redeem
f05bd8a
@MichelSantos
BSIP 40: Unit test of less than or equal to (le) and greater than (gt…
63bfd36 
…) restriction
@MichelSantos
BSIP 40: Unit test of variant assert (variant_assert) restriction
7f85447
@MichelSantos
BSIP 40: Unit test of CAA latest time
2fdc5ba
@MichelSantos
BSIP 40: Unit test of CAA earliest and latest time
48da405
@MichelSantos
BSIP 40: Unit test of proposed CAA earliest and latest time
f65b84d
@MichelSantos
BSIP 40: Unit test of optional field restriction
82aeb80
@MichelSantos
BSIP 40: Unit test of string field restriction
87ae8bf
@nathanielhourt
Copy link
Contributor

There are test errors in travis. The relevant logs start here

nathanielhourt
nathanielhourt suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@nathanielhourt nathanielhourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Michel! Great work. Just some small tweaks to make.

tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
tests/tests/custom_authority_tests.cpp Outdated Show resolved Hide resolved
@nathanielhourt
Copy link
Contributor

Looks great, thanks so much! =)

@pmconrad pmconrad merged commit dee35ee into bitshares:release Nov 7, 2019
@MichelSantos MichelSantos deleted the bsip40-unit-tests branch November 11, 2019 01:01
@MichelSantos MichelSantos mentioned this pull request Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielhourt nathanielhourt nathanielhourt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Protocol Upgrade Release (8.0.0)
Status: In progress
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
4 participants
@MichelSantos @nathanielhourt @pmconrad @abitmore