Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split wallet.cpp into smaller files #2013

Merged
merged 13 commits into from
Oct 2, 2019
Merged

Split wallet.cpp into smaller files #2013

merged 13 commits into from
Oct 2, 2019

Conversation

jmjatlanta
Copy link
Contributor

@jmjatlanta jmjatlanta commented Sep 24, 2019 •
edited by abitmore
Loading

Fixes #2003 #950

This will split wallet.cpp into smaller files to alleviate problems compiling such a large file.

The definition of the implementation was moved into a header, and some of the implementation of methods moved into separate .cpp files.

  • organize and move the rest of the methods into respective .cpp files

@crypto-ape
Copy link
Contributor

After rebasing to develop I had to split wallet.cpp into one more additional file, then it finally worked and I was able to compile everything with MinGW.

@jmjatlanta jmjatlanta marked this pull request as ready for review September 26, 2019 22:21
@jmjatlanta
Copy link
Contributor Author

After rebasing to develop I had to split wallet.cpp into one more additional file, then it finally worked and I was able to compile everything with MinGW.

I have cleaned up more of the implementations. Please try again and let me know if you have any problems. Thanks!

@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Sep 29, 2019
@abitmore abitmore mentioned this pull request Sep 29, 2019
Closed
@crypto-ape
Copy link
Contributor

After rebasing to develop I had to split wallet.cpp into one more additional file, then it finally worked and I was able to compile everything with MinGW.

I have cleaned up more of the implementations. Please try again and let me know if you have any problems. Thanks!

Compiles OK with MinGW 7.3 on Linux and Windows.

pmconrad
pmconrad suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@pmconrad pmconrad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed code was moved and reformatted as of daa7f95
Also confirmed that the gitian windows build works with this version.

libraries/wallet/include/graphene/wallet/operation_printer.hpp Outdated Show resolved Hide resolved
libraries/wallet/include/graphene/wallet/operation_printer.hpp Outdated Show resolved Hide resolved
libraries/wallet/include/graphene/wallet/reflect_util.hpp Show resolved Hide resolved
libraries/wallet/include/graphene/wallet/wallet_api_impl.hpp Outdated Show resolved Hide resolved
libraries/wallet/include/graphene/wallet/wallet_api_impl.hpp Outdated Show resolved Hide resolved
libraries/wallet/wallet_network.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet_sign.cpp Show resolved Hide resolved
libraries/wallet/wallet_sign.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet_sign.cpp Outdated Show resolved Hide resolved
libraries/wallet/wallet_voting.cpp Outdated Show resolved Hide resolved
pmconrad
pmconrad suggested changes Oct 1, 2019
View reviewed changes
libraries/wallet/wallet_debug.cpp Outdated Show resolved Hide resolved
@pmconrad
Copy link
Contributor

pmconrad commented Oct 2, 2019

Thanks! I would have grouped differently in some cases, but that's more a matter of personal taste.

@abitmore abitmore self-requested a review October 2, 2019 13:17
@jmjatlanta jmjatlanta merged commit fe108e5 into develop Oct 2, 2019
@jmjatlanta jmjatlanta deleted the jmj_2003 branch October 2, 2019 13:25
@jmjatlanta jmjatlanta mentioned this pull request Oct 2, 2019
Closed
9 tasks
@MichelSantos MichelSantos mentioned this pull request Oct 18, 2019
Closed
@pmconrad pmconrad mentioned this pull request Oct 19, 2019
Closed
3 tasks
@abitmore abitmore mentioned this pull request Jan 30, 2020
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

@pmconrad pmconrad pmconrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
5 participants
@jmjatlanta @crypto-ape @pmconrad @abitmore @ryanRfox