Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build (Linux/Clang) #1941

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Fix build (Linux/Clang) #1941

merged 1 commit into from
Aug 20, 2019

Conversation

nathanielhourt
Copy link
Contributor

Both G++ and Clang seem to need compiler extensions flags in order to provide std::numeric_limits specializations for 128-bit integer types. This commit enables these flags for Clang as well as G++.

@abitmore abitmore added this to the 3.3.0 - Feature Release milestone Aug 20, 2019
@abitmore abitmore mentioned this pull request Aug 20, 2019
Merged
@MichelSantos MichelSantos mentioned this pull request Aug 20, 2019
Closed
jmjatlanta
jmjatlanta approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 18.04 and 16.04 / Windows 10 / macOS

In the past, I have seen warnings about else and endif not matching if you don't give them the same parameters. But in this case, I saw none. I'll chalk it up to "magic"

@pmconrad pmconrad merged commit 1133ba3 into bitshares:release Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0 - Feature Release
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanielhourt @jmjatlanta @pmconrad @abitmore