-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding video link to BitOps to; README, index, getting-started #386
Conversation
Foresight Summary View More Details✅ CI workflow has finished in 35 seconds and finished at 18th Jan, 2023.
*You can configure Foresight comments in your organization settings page. |
docs/index.md
Outdated
<a class="md-button md-button--primary" href="getting-started">Show me the doc</a> | ||
<a class="md-button md-button--primary" href="https://youtu.be/BiytYu3EefY">Show me a video</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a class="md-button md-button--primary" href="getting-started">Show me the doc</a> | |
<a class="md-button md-button--primary" href="https://youtu.be/BiytYu3EefY">Show me a video</a> | |
<a class="md-button md-button--primary" href="getting-started">Show me the doc</a> |
One CTA button is enough.
Instead of "show me the video" button, the idea was to replace the big logo block and adding a video iframe of a similar size. Big BitOps logo is not informational and just takes a precious space.
Additionally, bitops logo image might need a rework to make it compact and inline <image> BitOps
so we still have it somewhere.
I can work on that, if you think it becomes too involved. Just let me know, can do it after a landing page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least change the linked image to pull from youtube
@@ -1,5 +1,8 @@ | |||
# Getting Started | |||
|
|||
<iframe width="1280" height="500" src="https://www.youtube.com/embed/BiytYu3EefY" title="Intro to BitOps" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" allowfullscreen></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to put this embed on the front page of bitops.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge the Readme update here and do the landing page in the next PR: #389 as I'd like more there with the list of bitops values and to align that w video
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging.
Let's do more on the landing page in the next PR: #389
Description
Updating documentation with BitOps intro video.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally tested with
docker-compose
Logs
Checklist: