Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with error when bitops.config.yaml not found #311

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Oct 3, 2022

Fixes #310

@arm4b arm4b added the bug 🪲 Something isn't working label Oct 3, 2022
@arm4b arm4b requested a review from PhillypHenning October 3, 2022 18:41
@arm4b arm4b enabled auto-merge October 3, 2022 18:46
Copy link
Contributor

@PhillypHenning PhillypHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for doing this so quickly.
Is it worth moving the description to the doc lookup file?

@arm4b
Copy link
Member Author

arm4b commented Oct 3, 2022

@PhillypHenning I think the lookup thing is outside of this PR scope as we want a fix which stops the code execution early in case of no config file provided.

If we want to switch into docs lookup way, we need to create a dedicated PR to go through all the errors, move them into lookup json and integrate into the docs so it works as one complete feature. Before the docs integration there's no value as it's harder to navigate the actual error from the code.

@arm4b arm4b added this to the v2.1.0 milestone Oct 5, 2022
@arm4b arm4b merged commit 9f79ccf into main Oct 12, 2022
@arm4b arm4b deleted the fix/310-bitops-config-not-found branch October 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File check - bitops.config.yaml
2 participants