Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy_plugins to exit with non-zero return code on error #268

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Aug 10, 2022

Command that's expected to fail:

docker run \                                                                       
-v $(pwd):/opt/bitops_deployment \
bitovi/bitops:dev

outputs error message as expected:

2022-08-10 12:08:08,065 root         ERROR The `BITOPS_ENVIRONMENT` variable must be set... Exiting.
		For more information on this issue please checkout our doc [https://bitovi.github.io/bitops/configuration-base/#environment]

But it's missing the proper non-zero exit code to signalize a failure in the terminal:

echo $?                                                                               ✔
0

This PR fixes it.

@arm4b arm4b added the bug 🪲 Something isn't working label Aug 10, 2022
@arm4b arm4b merged commit 357d174 into main Aug 11, 2022
@arm4b arm4b deleted the fix/deploy-plugins-rc branch August 11, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants