Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/minio]: Templating sleep sleep time so that it can be passed using values.yaml #30718

Merged
merged 19 commits into from
Dec 13, 2024
Merged

[bitnami/minio]: Templating sleep sleep time so that it can be passed using values.yaml #30718

merged 19 commits into from
Dec 13, 2024

Conversation

choudham
Copy link
Contributor

@choudham choudham commented Dec 2, 2024

Description of the change

This templates the sleep time for minio-provisioning job keeping the default at 5 sec.

Benefits

Easy to change using values.yaml

Applicable issues

(#30597)

Additional information

Checklist

Issue opened for this
(https://github.com/bitnami/charts/blob/main/CONTRIBUTING.md#sign-your-work)

@choudham
Update provisioning-job.yaml
38702b6 
Templating sleep time so that it can be passed using values.yaml

Signed-off-by: choudham <[email protected]>
@choudham
Update Chart.yaml
500a458 
Bumping Chart.yaml

Signed-off-by: choudham <[email protected]>
@github-actions github-actions bot added minio triage Triage is needed labels Dec 2, 2024
@github-actions github-actions bot requested a review from javsalgar December 2, 2024 20:51
@choudham
Update README.md
a160203 
Signed-off-by: choudham <[email protected]>
@bitnami-bot
Update CHANGELOG.md
65956a2 
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Dec 3, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 3, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 3, 2024 09:17
@github-actions github-actions bot requested a review from dgomezleon December 3, 2024 09:17
@bitnami-bot
Update CHANGELOG.md
f90ee43 
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
dgomezleon reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing.

I would suggest adding the new parameter to values.yaml. Otherwise, the README.md will be overwritten in a future PR and the note will be lost. Also, since it adds a new parameter, use version 14.9.0 instead.

@choudham
Update Chart.yaml
20ef0e2 
Signed-off-by: choudham <[email protected]>
@choudham
Update values.yaml
c309fb0 
Signed-off-by: choudham <[email protected]>
@choudham
Update Chart.yaml
e157ef7 
Signed-off-by: choudham <[email protected]>
@choudham
Update values.yaml
d02c658 
Signed-off-by: choudham <[email protected]>
@choudham
Update Chart.yaml
eb59415 
Signed-off-by: choudham <[email protected]>
@choudham
Update values.yaml
f036ba3 
Signed-off-by: choudham <[email protected]>
@choudham
Update Chart.yaml
c780382 
Signed-off-by: choudham <[email protected]>
@choudham
Merge branch 'main' into main
e2ceac2 
Signed-off-by: choudham <[email protected]>
@choudham choudham requested a review from dgomezleon December 9, 2024 23:13
@choudham
Copy link
Contributor Author

choudham commented Dec 9, 2024

Thanks for contributing.

I would suggest adding the new parameter to values.yaml. Otherwise, the README.md will be overwritten in a future PR and the note will be lost. Also, since it adds a new parameter, use version 14.9.0 instead.

@dgomezleon : Updated the PR. Request you to please review it again

dgomezleon
dgomezleon requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions required to fix README.md automation.

bitnami/minio/Chart.yaml Outdated Show resolved Hide resolved
bitnami/minio/values.yaml Show resolved Hide resolved
bitnami/minio/templates/provisioning-job.yaml Outdated Show resolved Hide resolved
choudham and others added 5 commits December 10, 2024 16:17
@choudham
Merge branch 'main' into main
ee7be8d 
Signed-off-by: choudham <[email protected]>
@dgomezleon
Update bitnami/minio/values.yaml
9e9d5a9 
Signed-off-by: David Gomez <[email protected]>
@choudham
Update Chart.yaml
1cf453f 
Signed-off-by: choudham <[email protected]>
@bitnami-bot
Update CHANGELOG.md
8c7b879 
Signed-off-by: Bitnami Containers <[email protected]>
@bitnami-bot
Update README.md with readme-generator-for-helm
f7b5136 
Signed-off-by: Bitnami Containers <[email protected]>
@choudham choudham requested a review from dgomezleon December 13, 2024 00:58
@choudham
Copy link
Contributor Author

@dgomezleon : All looks good in terms of the check. Please review and help us merge this :)

@dgomezleon dgomezleon merged commit ea21cb8 into bitnami:main Dec 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patila-hpe patila-hpe patila-hpe approved these changes

@dgomezleon dgomezleon dgomezleon approved these changes

Assignees

@dgomezleon dgomezleon

Labels
minio solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@choudham @dgomezleon @patila-hpe @javsalgar @bitnami-bot