Skip to content

Commit

Permalink
Add feedback by Melroy (#35)
Browse files Browse the repository at this point in the history
  • Loading branch information
melroy89 authored Oct 30, 2024
1 parent 3686ff1 commit 9b1e893
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion stakeholders.md
Original file line number Diff line number Diff line change
Expand Up @@ -883,4 +883,9 @@ _(None)_

The following statements have been submitted from individuals and organizations that abstained from approving this CHIP.

_(None)_
> I validated the overall [MR 1891](https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/1891) for the VM Limits and BigInt CHIPs with the updated LibAuth and benchmark scheme. I performed benchmarks and executed the test plan. After that I [shared my results](https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/1891#note_2138753900) with the BCHN development team, everything looks good and results match expectation (and my CPU is apparently 30% faster than from Calin ^^).
>
> Although I'm not the expert of the BCHN code source, everything does seems to work as expected eventually and compiling now also works without any warnings. Despite not having the deeper knowledge about the technical implementation of the CHIPs, better performance is always very welcome! Specifically in favour of the reduced transaction sizes; same for reduction of storage as well as CPU usage reduction. I'm running a full node after all.
> _Disclaimer:_ I didn't yet run production or load testing with the latest CHIPs. If I find any regression, I will report it via GitLab / Slack.
>
> —<cite>Melroy van den Berg, [Melroy's BCH Explorer](https://explorer.melroy.org), [Melroy.org](https://melroy.org)</cite>

0 comments on commit 9b1e893

Please sign in to comment.