Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CJS and ESM support #2161

Merged
merged 7 commits into from
Sep 8, 2024
Merged

Add CJS and ESM support #2161

merged 7 commits into from
Sep 8, 2024

Conversation

Nesopie
Copy link
Contributor

@Nesopie Nesopie commented Sep 4, 2024 •
edited
Loading

  • Add support for CJS and ESM
  • Moved from typeforce (does not have esm support) to Valibot
  • Replaced Buffer usage to Uint8Array
  • There are 44 less test cases now as all logic with regards to writeUint64 and related functions has been moved to uint8array-tools.
  • All amount / value fields now use bigints

junderw
junderw approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend!

Let's publish rc1 versions of all the major dependencies, then fix them in package.json here, then push rc1 version for bitcoinjs-lib.

@junderw junderw merged commit d6fe656 into bitcoinjs:master Sep 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nesopie @junderw