Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP340: minor grammar edits #1706

Merged
merged 1 commit into from
Dec 4, 2024
Merged

BIP340: minor grammar edits #1706

merged 1 commit into from
Dec 4, 2024

Conversation

Gudnessuche
Copy link
Contributor

In order for this section to fully be grasped by readers, minor grammatical errors need to be fixed, especially when explaining the "Nonce exfiltration protection" and "Precomputed public key data"

In order for this section to fully be grasped by readers, minor grammatical errors need to be fixed, especially when explaining the "Nonce exfiltration protection"
@jonatack jonatack changed the title Update on Alternative Signing (minor adjustment) BIP340: minor grammar edits Dec 4, 2024
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. This change is arguably not worth the review time, and the writing style it fixes is fairly common in the BIPs, but ok this time.

@jonatack jonatack merged commit 410a7bc into bitcoin:master Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants