feat: Check if Include folders/files do exists (in case they are removed) #1718
Conversation
Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings. reference: bit-team#1586
|
This is not complete yet, but if possible I would like some feedback before finishing it. Are the messages good? And I am wondering if the qt warning is ok (it is asking a confirmation before continuing instead of just warning). And I didn't implement a) for no big reason. I am still getting familiar with the code and b) was something that was more clear for me. I could try a) in a future PR. And how you normally do translations? I was planning to translate all other languages using some automated tool (Copilot) but I wanted to confirm how you guys do it normally... |
|
Dear Rafael, I added some comments and suggestions to the code. I am not sure about the whole solution. I would suggest to further discuss it in the related issue #1586. I will set the PR into Draft mode to state the the solution is not finished. Best, |
Co-authored-by: buhtz <[email protected]>
Co-authored-by: buhtz <[email protected]>
Co-authored-by: buhtz <[email protected]>
Co-authored-by: buhtz <[email protected]>
|
I appreciate a lot for the review. It clarified a lot of questions and taught me some good lessons (I would never have thought about RTL issues on translations). And I am happy about not use the camel case :) I will do the fixes from the review and wait for any suggestion in the original issue. Thank you very much 🙏 |
refactor btn snapshot & improve translate message Co-authored-by: buhtz <[email protected]>
|
Does anyone know how to trigger the systray-icon message-bubbles via BIT? I tried with "Snapshot.setTakeSnapshotMessage(1, 'FOO BAR')" but without success. This message appears in the status bar of the main window. |
Me neither. When I started to work on the translation task I thougt it is easy. I learned things like that from translators and the community around them while trying to attract translators to BIT. |
buhtz
added
Discussion
|
FYI: I am AFK for one week and will review this PR when I am back... |
|
Hello Rafael, |
|
Copy & Paste ... Using Firstly, excessive Additionally, it's often unnecessary to mention admins or moderators directly, as they are usually subscribed to relevant issues or pull requests and will receive notifications automatically. |
|
I apologize about the mention :( |
I had no time for longer than expected but I plan to do the review tomorrow (sorry for not informing you earlier!). |
There was a problem hiding this comment.
@rafaelhdr I have done the code review with some (more or less cosmetic) findings only. Could you please check my review findings and pull the changes (or discuss different solutions here)? THX a lot :-)
PS: I will do some manual tests on my own then using my personal testing profiles...
buhtz
added
Feedback
buhtz
changed the title
|
Hello, How is your schedule? Can I plan your PR for this release (1.6.0) or for the release after it (1.6.1)? Regards, |
|
Hello I think it would be great :) But I am very new here (this is my second Pull Request in the project). It would be great to have someone with more experience and I am available to do any fix. |
There was a problem hiding this comment.
OK, I checked the old review comments.
Now you should see only four pending/open review comments added by me.
You can use the "Commit suggestion" button if you want.
About aryoda's review: I would say all comments from him are solved. But I am not able to "accept" the the changes to his review on the GitHub interface. I can only click "dismiss review", which I don't want to. ;) So just treat his comments as solved.
I also updated your branch to the latest dev version. So make sure you also update your local branch at your working machine.
I would like to do some more manual tests before merging.
Let me know if you have questions or if I can be of assistance.
| Check if files and/or folders in the include list exist on the source. | ||
|
|
||
| If a file or folder does not exist, a warning message is logged. | ||
|
|
||
| Args: | ||
| cfg (config.Config): config that should be used |
There was a problem hiding this comment.
| Check if files and/or folders in the include list exist on the source. | |
| If a file or folder does not exist, a warning message is logged. | |
| Args: | |
| cfg (config.Config): config that should be used | |
| Check if files and/or directories in the include list exist on the source. | |
| If a file or directory does not exist, a warning message is logged. | |
| Args: | |
| cfg (config.Config): Config that should be used. |
| msg = _('The following folders are missing: {folders} Do you want to proceed?'.format( | ||
| folders=f'\n{msg_missing}\n\n')) |
There was a problem hiding this comment.
| msg = _('The following folders are missing: {folders} Do you want to proceed?'.format( | |
| folders=f'\n{msg_missing}\n\n')) | |
| msg = _('The following directories are missing: {dirs} Do you want to proceed?'.format( | |
| dirs=f'\n{msg_missing}\n\n')) |
|
|
||
| if missing: | ||
| msg = ', '.join(missing) | ||
| msg = f'The following **files/**folders are missing: {msg}' |
There was a problem hiding this comment.
Why are these ** in the message? I would suggest "The following files/directories are missing: {msg}"
btw: We decided to use the technical more precise term "directory" instead of "folder".
| describing the missing files or folders | ||
| """ | ||
| not_found = [] | ||
| for path, info in included: |
There was a problem hiding this comment.
The linter failes because "info" is not used anymore.
snapshots.py:3170:14: W0612: Unused variable 'info' (unused-variable)
Solution b) when start taking a snapshot the include list should be checked of existence first and warn about missings.
reference: #1586