Embedders widget - field for a custom server URL #114
Conversation
PrimozGodec
force-pushed
the
embedders-server
branch
2 times, most recently
from
72c3335 to
255341b
Compare
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
- Coverage 79.9% 76.18% -3.73%
==========================================
Files 7 5 -2
Lines 622 529 -93
Branches 95 84 -11
==========================================
- Hits 497 403 -94
- Misses 97 98 +1
Partials 28 28 |
PrimozGodec
changed the title
| @@ -105,6 +116,15 @@ def _setup_layout(self): | |||
| EMBEDDERS_INFO[current_embedder]['description'] | |||
| ) | |||
|
|
|||
| advanced_box = widgetBox(self.controlArea, 'Advanced settings') | |||
There was a problem hiding this comment.
Advanced server settings
or maybe just
Custom server
| @@ -105,6 +116,15 @@ def _setup_layout(self): | |||
| EMBEDDERS_INFO[current_embedder]['description'] | |||
| ) | |||
|
|
|||
| advanced_box = widgetBox(self.controlArea, 'Advanced settings') | |||
| self.use_custom_server_cb = checkBox( | |||
| advanced_box, self, 'custom_server', "User custom server", | |||
| advanced_box, self, 'custom_server', "User custom server", | ||
| callback=self.changed_server_url) | ||
| self.server_url_box = lineEdit( | ||
| advanced_box, self, 'server_url', label="Server URL: ", |
There was a problem hiding this comment.
I think this could be disabled when the above checkbox is not checked.
|
we also need "allow insecure" option, eg. like in curl -k or --insecure (Allow connections to SSL sites without checking certs (H)). We need this if there are self signed certificates installed on the imageanalytics server. |
PrimozGodec
force-pushed
the
embedders-server
branch
from
255341b to
204b651
Compare
|
@matjazp it seems that hyper library does not support "allow insecure" option https://hyper.readthedocs.io/en/latest/advanced.html#ssl-tls-certificate-verification. With @acopar we discussed to just use HTTP instead of HTTPS those cases |
PrimozGodec
force-pushed
the
embedders-server
branch
from
204b651 to
7bf30c6
Compare
|
Very useful!! |
PrimozGodec
force-pushed
the
embedders-server
branch
from
3305200 to
fd86858
Compare
PrimozGodec
force-pushed
the
embedders-server
branch
from
fd86858 to
734fe7b
Compare
Issue
No possibility to set custom server url.
Description of changes
Adding a field and functionality for a custom URL set.
Includes