Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seq-hasher #50776

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Add seq-hasher #50776

merged 7 commits into from
Sep 19, 2024

Conversation

apcamargo
Copy link
Contributor

This PR adds seq-hasher, a tool for fast computation of hash digests for DNA sequences in FASTA files, with support for circular permutations.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@apcamargo
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Sep 18, 2024
recipes/seq-hasher/build.sh Outdated Show resolved Hide resolved
@mbhall88
Copy link
Contributor

mbhall88 commented Sep 19, 2024

I would also suggest following the conda-forge documentation for bundling licenses from dependencies. https://conda-forge.org/docs/maintainer/adding_pkgs/#rust. re: #50800

Comment on lines 9 to 10
script:
- cargo-bundle-licenses --format yaml --output THIRDPARTY.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you have a build.sh, adding this script: directive will make the build not use that script I believe. Move the cargo-bundle-licenses --format yaml --output THIRDPARTY.yml into the build.sh. Take a look at https://github.com/conda-forge/ssubmit-feedstock/tree/main/recipe for an example

@mbhall88 mbhall88 mentioned this pull request Sep 19, 2024
@mbhall88
Copy link
Contributor

And while I'm being annoying, I might also recommend adding --no-track to the install command conda-forge/conda-forge.github.io#2191

@bioconda bioconda deleted a comment from mbhall88 Sep 19, 2024
@mbhall88 mbhall88 merged commit 9b79b32 into bioconda:master Sep 19, 2024
6 checks passed
@apcamargo apcamargo deleted the seq-hasher branch October 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants