build: convert package-lock.json to v2, add engines.node >= 16 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbb-pads was introduced in BBB 2.5 which has Node.js 16 (LTS) as the baseline for most apps. That node version usually comes with npm 8 - which converts lockfiles to v2 on install since it is the default. This commit does two things: specify engines.node in package.json for autodocumenting purposes and convert package-lock.json to lockfileVersion 2 so that it isn't converted by the build system on every build.
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bbb-pads was introduced in BBB 2.5 which has Node.js 16 (LTS) as the
baseline for most apps. That node version usually comes with npm 8 -
which converts lockfiles to v2 on install since it is the default.
This commit does two things: specify engines.node in package.json for
autodocumenting purposes and convert package-lock.json to
lockfileVersion 2 so that it isn't converted by the build system on
every build.