Fix data export #344
Draft
Fix data export #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks alright to me. |
|
So before this line: would fetch zero rows when the $3 is nil. And we would get the error as shown in #334 Now, it should not error if you actually have matches. If you don't have any matches at all it would error but that would only occur if you didn't run the |
|
This no longer passes tests so setting to draft. Also it might not be needed because there may other ways to access the data if we set up data dumps. |
L-e-x-o-n
reviewed
Aug 6, 2024
Comment on lines
+113
to
+134
| defp get_match_count_query(start_date, end_date, rating_type_id) do | ||
| query = """ | ||
| SELECT COUNT(id) | ||
| FROM teiserver_battle_matches | ||
| WHERE | ||
| started >= $1 | ||
| AND finished < $2 | ||
| AND processed = true | ||
| AND winning_team IS NOT NULL | ||
| AND finished IS NOT NULL | ||
| AND started IS NOT NULL | ||
| """ | ||
|
|
||
| if(rating_type_id == nil) do | ||
| Ecto.Adapters.SQL.query(Repo, query, [start_date, end_date]) | ||
| else | ||
| query = query <> " AND rating_type_id = $3" | ||
|
|
||
| Ecto.Adapters.SQL.query(Repo, query, [start_date, end_date, rating_type_id]) | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Only this change is needed now. The rest has been fixed with team split fixes.
L-e-x-o-n
requested changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Done
Fixes #334
Also allows filtering by Small Team and Large Team when exporting data
Test Steps