Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements and a "bugfix" | context menus #164

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

BUGO07
Copy link
Contributor

@BUGO07 BUGO07 commented Dec 6, 2024

when opening the context menu, if you were holding down the right click and then hovered over a context menu option, when you'd release the right click it would execute that context menu action, that's been fixed by making the context menu spawn trigger be Pointer<Up> instead of Pointer<Down>, and also made the context menu options to trigger only on left click (primary button)

@BUGO07
Copy link
Contributor Author

BUGO07 commented Dec 6, 2024

this pr also makes it so when a context menu is open and you try to open another, it closes the currently open one and opens the new one. previously you would need to right click twice for this (once to close the current one and the second time to open the new one)

@tim-blackbird
Copy link
Contributor

tim-blackbird commented Dec 6, 2024

All of this was designed on purpose by me. Context menus generally behave this way.
I can't confirm it works this way on MacOS, but it does for Linux KDE and VS Code
edit:
Okay nevermind, we are both right. It's OS specific. On Linux KDE both the native context menu and the one in VS Code behave this way, but on Windows it functions like you describe.

So we need a way to decide how the context menu should behave on different platforms.

@BUGO07
Copy link
Contributor Author

BUGO07 commented Dec 6, 2024

I didn't know. I think it can be a bit annoying when you're moving the cursor while you right click and it does an action, especially since there's delete buttons in the context menus

@BUGO07
Copy link
Contributor Author

BUGO07 commented Dec 6, 2024

So we need a way to decide how the context menu should behave on different platforms.

I think we can do that with preferences after we get there

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 6, 2024
Merged via the queue into bevyengine:main with commit 6d3b457 Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants