Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986
We were largely just missing a bunch of
#[reflect(Component)]
calls, but also some type registrations. We now automatically registerHandle<T>
when an asset is registered.I did need to make
Handle<T>::from_weak_u64
non-const to make the derive work (I moved that method to HandleUntyped). I'm considering a manual Handle reflect impl instead (which would probably allow us to keep constHandle<T>