Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing chrome span names #979

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Tracing chrome span names #979

merged 3 commits into from
Dec 3, 2020

Conversation

superdump
Copy link
Contributor

This should work in theory but for some reason the tracing-chrome profile data is not being properly flushed to the .json file it creates. I wonder if the thread-local resource isn't doing what we want it to?

@cart
Copy link
Member

cart commented Dec 2, 2020

Works for me!

cargo run --example 3d_scene --release --features trace,trace_chrome

image

@memoryruins memoryruins added core C-Feature A new feature, making something new possible labels Dec 2, 2020
@superdump
Copy link
Contributor Author

Works for me!

cargo run --example 3d_scene --release --features trace,trace_chrome

image

I forgot to enable the trace feature. Works for me too now. Yey!

@cart cart merged commit 59010ca into bevyengine:master Dec 3, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambeeeeee ambeeeeee ambeeeeee left review comments

Assignees
No one assigned
Labels
C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superdump @cart @ambeeeeee @memoryruins