Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Time API and internals #934

Merged
merged 8 commits into from
Nov 28, 2020
Merged

Refactor Time API and internals #934

merged 8 commits into from
Nov 28, 2020

Conversation

ambeeeeee
Copy link
Contributor

This PR changes a few things about Time:

  • Member access has been replaced with getters
  • Changed instant to last_update to increase clarity
  • Added tests for Time functionality

The added test checks all the functionality of Time, which should be useful.

I'd like some feedback from @cart, since I was wondering if we should make Time::update private (pub crate or similar) since there's little reason for it to be used outside of bevy.

Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple small nits

CHANGELOG.md Show resolved Hide resolved
crates/bevy_core/src/time/time.rs Outdated Show resolved Hide resolved
@ambeeeeee ambeeeeee requested a review from cart November 28, 2020 04:48
@Moxinilian Moxinilian added C-Code-Quality A section of code that is hard to understand or change core labels Nov 28, 2020
@cart cart merged commit 097a559 into bevyengine:master Nov 28, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants