bevy_reflect: Default attribute paths #9323
Open
+11
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Followup to #9322 but with a breaking change.
With
syn2
, it's a whole lot easier to customize attributes. One small improvement we could make would be to change thedefault
attribute to take a type path directly instead of a stringified path.Solution
Updated the parsing logic to take an
ExprPath
directly.Changelog
#[reflect(default)]
no longer need to be string literals (i.e. they can specify the path directly like#[reflect(default = path::to::func)]
)Migration Guide
The optional function passed to
#[reflect(default)]
is no longer a stringified path. It can now be a standard type path: