Create winit windows before app.initialize() #916
Conversation
|
This commit restores code that was removed in #879 |
|
Haha this one is my fault. @bjorn3 mentioned that the line wasn't necessary and I totally forgot that we added it for a reason. Can you add a comment above that line to indicate why its there to protect future contributors from future me? |
This is required so startup systems have access to Windows and WinitWindows resources.
|
Sure. Done. |
Moxinilian
added
C-Bug
|
I cannot see the comment being added, are you sure you pushed it properly? |
|
I did, then I force-pushed it gone. I force-pushed it back again now. I really should not be doing PRs from |
| @@ -147,6 +147,14 @@ pub fn winit_runner(mut app: App) { | |||
|
|
|||
| app.resources.insert_thread_local(event_loop.create_proxy()); | |||
|
|
|||
| // Create Windows and WinitWindows resources, so startup systems | |||
| // in below app.initialize() have access to them. | |||
There was a problem hiding this comment.
I'd take out "in below app.initialize()" but that's not a big deal.
// Create Windows and WinitWindows resources so
// startup systems have access to them.
There was a problem hiding this comment.
The goal of this mention is so one do not move the call below app.initialize() as this would render it useless.
This is required so startup systems have access
to Windows and WinitWindows resources.