-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the Texture asset type to support 3D data #903
Conversation
I also think it would be nice to replace the |
One thing I am surprised by: I didn't have to change the |
Please run |
Just failing to install udev now. |
A rebase should do the trick. I like all of these changes. My biggest question mark is "should we have 2d variants of methods on Texture or just let everyone contend with the fact that its 3d now?" Its not that much harder to deal with and it keeps the api surface smaller. I have a slight bias toward removing the 2d variants (with the exception of |
@cart I think I am fine with removing the 2d methods, except aspect, like you said. What do you think about replacing the |
Yeah I'm cool with that. |
Textures are still loaded from images as 2D, but they can be reshaped according to how the render pipeline would like to use them. Also add an example of how this can be used with the texture2DArray uniform type.
… field use the Extent3d type
Textures are still loaded from images as 2D, but they can be reshaped according to how the render pipeline would like to use them.
Also add an example of how this can be used with the texture2DArray uniform type.