Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant texture copies in TextureCopyNode #871

Merged
merged 4 commits into from
Nov 17, 2020
+8 −0
Merged

Remove redundant texture copies in TextureCopyNode #871

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
acf3299
Remove redundant texture syncs in TextureCopyNode
4-rodrigo-salazar Nov 16, 2020
5e317d2
Use word 'copied' and not 'synced'
4-rodrigo-salazar Nov 16, 2020
17736b6
Missing import..
4-rodrigo-salazar Nov 16, 2020
1211764
Fix return bug
4-rodrigo-salazar Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/bevy_render/src/render_graph/nodes/texture_copy_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use crate::{
use bevy_app::prelude::{EventReader, Events};
use bevy_asset::{AssetEvent, Assets};
use bevy_ecs::{Resources, World};
use bevy_utils::{AHashExt, HashSet};

#[derive(Default)]
pub struct TextureCopyNode {
Expand All @@ -23,10 +24,15 @@ impl Node for TextureCopyNode {
) {
let texture_events = resources.get::<Events<AssetEvent<Texture>>>().unwrap();
let textures = resources.get::<Assets<Texture>>().unwrap();
let mut copied_textures = HashSet::new();
for event in self.texture_event_reader.iter(&texture_events) {
match event {
AssetEvent::Created { handle } | AssetEvent::Modified { handle } => {
if let Some(texture) = textures.get(handle) {
if copied_textures.contains(&handle.id) {
continue;
}

let texture_descriptor: TextureDescriptor = texture.into();
let width = texture.size.x() as usize;
let aligned_width = render_context
Expand Down Expand Up @@ -67,6 +73,8 @@ impl Node for TextureCopyNode {
texture_descriptor.size,
);
render_context.resources().remove_buffer(texture_buffer);

copied_textures.insert(&handle.id);
}
}
AssetEvent::Removed { .. } => {}
Expand Down