Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain default behavior of AssetServer in the asset_loading example #822

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Explain default behavior of AssetServer in the asset_loading example #822

merged 2 commits into from
Nov 11, 2020

Conversation

ambeeeeee
Copy link
Contributor

It's unclear where the default AssetServer gets its assets from, so I thought it would be beneficial to explain it in the dedicated asset loading example. This is proven to be an issue for people using bevy by #810, and explaining it in the dedicated asset loading example may be beneficial. This would be complimented by #821, as the error would make it clear where bevy was looking for the asset.

I don't know if it would be beneficial to modify any other examples. I figure that if someone has issues with asset loading they'd probably check the example to see if it has any insight.

@Moxinilian Moxinilian added A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation labels Nov 9, 2020
@cart
Copy link
Member

cart commented Nov 9, 2020

Very good call. I removed one of the two examples as I think they were redundant / a little to noisy. Thanks!

@cart cart merged commit 096ac4a into bevyengine:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants