Keyboard keycode to qwerty char #782
Conversation
Jerald
force-pushed
the
keyboard-keycode-to-char
branch
from
a03f1cb to
c49cffd
Compare
karroffel
added
C-Feature
| /// let c3 = KeyCode::End.to_qwerty_char(true); | ||
| /// assert_eq!(c3, None); | ||
| /// ``` | ||
| pub fn to_qwerty_char(self, shift_down: bool) -> Option<char> { |
There was a problem hiding this comment.
I think calling this qwerty isn't quite correct. It seems like this would work equally well on an AZERTY keyboard. How about just to_char()?
There was a problem hiding this comment.
The chars don't match for Key1 to Key0 between azerty and qwerty.
For example, with azerty you have to press shift to get the number
There was a problem hiding this comment.
Arg gotcha gotcha. in that case idk if hard-coding qwerty is the right answer. I don't want to optimize bevy apis for specific regions.
Maybe we should just create a new event for ReceivedCharacter?
There was a problem hiding this comment.
Realistically, the "correct" approach would be to have different keysets/locales which you run key codes through and which each have conversions. Localization in general is a remarkably complex problem...
Because of this, I was imagining this as a sort of "stop-gap" solution until the proper work would be done.
But looking at that winit event you linked, implementing a new input thing which hooks into that event to supply direct text would likely be the better and more cross-platform solution...
| /// let c3 = KeyCode::End.to_qwerty_char(true); | ||
| /// assert_eq!(c3, None); | ||
| /// ``` | ||
| pub fn to_qwerty_char(self, shift_down: bool) -> Option<char> { |
There was a problem hiding this comment.
I think we should probably remove this method. We don't need two ways to get characters with/without shift.
How about just to_char() and to_char_with_shift()
|
We should not be implementing key to character mapping ourselves - it is a maintenance nightmare. i.e. I'd rather see |
|
I've now opened a new PR (#804) based on the winit Closing this PR in favour of that one. |
Adds functions that convert a
KeyCodeinto the equivalent textual char on a qwerty keyboard, based on the status of shift at the time.In addition, fixed a typo in the enum variant names where "Asterisk" was incorrectly called "Asterix".