-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for getting and setting individual color channels for all color spaces. #7759
Add methods for getting and setting individual color channels for all color spaces. #7759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good! Left some very minor comments re: naming, method consolidation and behavior of setters, but after that, 👍 from me
For the docs on all the I so much want to remove that file 🙁 |
I personally think using a crate like palette is the way to go |
Fixed in #920. Choice was made fairly arbitrarily; feel free to submit follow-up PRs for nits. |
Objective
Fixes #7746 except for making them const which is blocked on const float arithmetic.
Solution
Added a bunch more methods for getting and setting individual color channels for every color space.
Changelog
Added
X_Y
Get the Y value in linear X colorspace.set_X_Y
Set the Y value in X colorspace.with_X_Y
Returns this color with Y set to a new value in X colorspace.For all the remaining channels and color spaces.