fix mesh allocation bug and public mesh api improvements #768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #764
This removes attribute_buffer_descriptor_reference from Mesh in favor of computing it on demand. This prevents the "mesh asset change event" from triggering .
I also refactored some things and encapsulated the Mesh fields in favor of accessor methods. This allows us to cut down on user facing boilerplate and makes the backing attribute hashmap an implementation detail.
@julhe I also removed the sorting to cut down on the cost of computing VertexBufferDescriptor. I know I asked you to sort, but now that we're computing the descriptor more frequently its worth optimizing.
Long term I think we should avoid re-computing the VertexBufferDescriptor. Instead we should adopt something like this: